Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for the low-level REST client on JDK 7 #38540

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Drop support for the low-level REST client on JDK 7 #38540

merged 3 commits into from
Feb 9, 2019

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Feb 6, 2019 •
edited
Loading

This commit bumps the minimum compiler version on the low-level REST client to JDK 8.

Closes #29607

@jasontedor jasontedor added >breaking :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch v7.0.0 v8.0.0 v7.2.0 labels Feb 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jasontedor
Drop support for the low-level REST client on JDK 7
88619ec 
This commit bumps the minimum compiler version on the low-level REST
client to JDK 8.
@jakelandis
Copy link
Contributor

+1 on this change.

However, there are a couple more Java 7 mins in here too. We should probably bump those too ?

elasticsearch $ grep -R VERSION_1_7 . --include=*.gradle | grep -v distribution
./client/sniffer/build.gradle:targetCompatibility = JavaVersion.VERSION_1_7
./client/sniffer/build.gradle:sourceCompatibility = JavaVersion.VERSION_1_7
./client/test/build.gradle:targetCompatibility = JavaVersion.VERSION_1_7
./client/test/build.gradle:sourceCompatibility = JavaVersion.VERSION_1_7
./client/rest/build.gradle:targetCompatibility = JavaVersion.VERSION_1_7
./client/rest/build.gradle:sourceCompatibility = JavaVersion.VERSION_1_7

@jasontedor
Copy link
Member Author

Thanks @jakelandis. I pushed.

jakelandis
jakelandis approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor
Merge branch 'master' into llrc-java-7
b6612e9 
* master:
  Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636)
  add geotile_grid ref to asciidoc (elastic#38632)
  Enable Dockerfile from artifacts.elastic.co (elastic#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634)
  Account for a possible rolled over file while reading the audit log file (elastic#34909)
  Mute failure in InternalEngineTests (elastic#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518)
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  Mute failing WatchStatusIntegrationTests (elastic#38621)
  Mute failing  ApiKeyIntegTests (elastic#38614)
  [DOCS] Add warning about bypassing ML PUT APIs (elastic#38509)
  Add 7.1 and 8.0 version constants to master (elastic#38514)
@jasontedor
Copy link
Member Author

@elasticmachine test this please

@jasontedor jasontedor merged commit 8f4693f into elastic:master Feb 9, 2019
@jasontedor jasontedor deleted the llrc-java-7 branch February 9, 2019 00:47
jasontedor added a commit that referenced this pull request Feb 9, 2019
@jasontedor
Drop support for the low-level REST client on JDK 7 (#38540)
6abe998 
This commit bumps the minimum compiler version on the low-level REST
client to JDK 8.
jasontedor added a commit that referenced this pull request Feb 9, 2019
@jasontedor
Drop support for the low-level REST client on JDK 7 (#38540)
c115909 
This commit bumps the minimum compiler version on the low-level REST
client to JDK 8.
jasontedor added a commit to liketic/elasticsearch that referenced this pull request Feb 10, 2019
@jasontedor
Merge branch 'master' into pr/28895
e3508d1 
* master: (1159 commits)
  Fix timezone fallback in ingest processor (elastic#38407)
  Avoid polluting download stats on builds (elastic#38660)
  SQL: Prevent grouping over grouping functions (elastic#38649)
  SQL: Relax StackOverflow circuit breaker for constants (elastic#38572)
  [DOCS] Fixes broken migration links (elastic#38655)
  Drop support for the low-level REST client on JDK 7 (elastic#38540)
  [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (elastic#38641)
  fix dissect doc "ip" --> "clientip" (elastic#38545)
  Concurrent file chunk fetching for CCR restore (elastic#38495)
  make DateMathIndexExpressionsIntegrationIT more resilient (elastic#38473)
  SQL: Replace joda with java time (elastic#38437)
  Add fuzziness example (elastic#37194) (elastic#38648)
  Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636)
  add geotile_grid ref to asciidoc (elastic#38632)
  Enable Dockerfile from artifacts.elastic.co (elastic#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634)
  Account for a possible rolled over file while reading the audit log file (elastic#34909)
  Mute failure in InternalEngineTests (elastic#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518)
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  ...
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 11, 2019
@jasontedor
Merge branch 'master' into retention-lease-ccr
baec3a0 
* master:
  Fix timezone fallback in ingest processor (elastic#38407)
  Avoid polluting download stats on builds (elastic#38660)
  SQL: Prevent grouping over grouping functions (elastic#38649)
  SQL: Relax StackOverflow circuit breaker for constants (elastic#38572)
  [DOCS] Fixes broken migration links (elastic#38655)
  Drop support for the low-level REST client on JDK 7 (elastic#38540)
  [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (elastic#38641)
  fix dissect doc "ip" --> "clientip" (elastic#38545)
  Concurrent file chunk fetching for CCR restore (elastic#38495)
  make DateMathIndexExpressionsIntegrationIT more resilient (elastic#38473)
  SQL: Replace joda with java time (elastic#38437)
  Add fuzziness example (elastic#37194) (elastic#38648)
@lcawl lcawl mentioned this pull request Apr 9, 2019
Merged
javanna added a commit to javanna/elasticsearch that referenced this pull request Apr 25, 2019
@javanna
Adapt low-level REST client to java 8
9cd5e0b 
As a follow-up to elastic#38540 we can use lambda functions and method
references where convenient in the low-level REST client.

Also, we need to update the docs to state that the minimum java version
required is 1.8.
@javanna javanna mentioned this pull request Apr 25, 2019
Merged
javanna added a commit that referenced this pull request May 3, 2019
@javanna
Adapt low-level REST client to java 8 (#41537)
ee51702 
As a follow-up to #38540 we can use lambda functions and method
references where convenient in the low-level REST client.

Also, we need to update the docs to state that the minimum java version
required is 1.8.
javanna added a commit to javanna/elasticsearch that referenced this pull request May 22, 2019
@javanna
Adapt low-level REST client to java 8 (elastic#41537)
15ad400 
As a follow-up to elastic#38540 we can use lambda functions and method
references where convenient in the low-level REST client.

Also, we need to update the docs to state that the minimum java version
required is 1.8.
javanna added a commit that referenced this pull request May 22, 2019
@javanna
Adapt low-level REST client to java 8 (#41537)
e747326 
As a follow-up to #38540 we can use lambda functions and method
references where convenient in the low-level REST client.

Also, we need to update the docs to state that the minimum java version
required is 1.8.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@javanna
Adapt low-level REST client to java 8 (elastic#41537)
fe96705 
As a follow-up to elastic#38540 we can use lambda functions and method
references where convenient in the low-level REST client.

Also, we need to update the docs to state that the minimum java version
required is 1.8.
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees
No one assigned
Labels
>breaking :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch v7.0.0-beta1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop java 7 support for Java low-level REST Client
4 participants
@jasontedor @elasticmachine @jakelandis @jimczi